Skip to content

🌱 unbreak vscode-test on VS Code 1.131.0 and the changelog check (#1480) - #1481

Merged
fabianvf merged 1 commit into
release-0.6from
cherry-pick-pr1480-release-0.6
Aug 6, 2026
Merged

🌱 unbreak vscode-test on VS Code 1.131.0 and the changelog check (#1480)#1481
fabianvf merged 1 commit into
release-0.6from
cherry-pick-pr1480-release-0.6

Conversation

@konveyor-ci-bot

Copy link
Copy Markdown

Summary

Test (macos) has been failing on every PR since VS Code 1.131.0
shipped, and Verify changelog fragment fails on every fork PR. Both
are broken on main, not by any particular change. Confirmed by running
npx vscode-test on a clean ed42f5a checkout.

  • 1.131.0 dropped Contents/MacOS/Electron for Contents/MacOS/Code,
    and @vscode/test-electron 2.x still spawns the old name.
    .vscode-test.mjs pins no version so it picks up stable at run time,
    which is why this started on its own. 🐛 Validate custom rules file types in profile file dialog #1477 passed on 1.130.0. macOS
    failing then cancels linux and windows via fail-fast, so all three go
    red.
  • Bump @vscode/test-electron to 3.x. That gets it launching and
    exposes a second macOS failure underneath: VS Code opens a unix socket
    in its user data dir, and the default .vscode-test/user-data path is
    over the 104 byte sun_path limit. CI's macOS path is exactly 104, so
    the bump on its own would have swapped one failure for another. Point
    --user-data-dir at a short temp path.
  • @vscode/test-cli stops at 0.0.14 on purpose. 0.0.15 pulls
    yargs@18, which wants node ^22.12.0, and .nvmrc is v22.9.0, so
    install dies with EBADENGINE before anything runs. Bumping .nvmrc
    would also work but that is a bigger call than this PR should make.
  • The changelog job checks out the PR head, which actions/checkout now
    refuses under pull_request_target since that runs fork code with a
    privileged token. It only needs the changed filenames, so ask the API
    for them instead. Avoids opting into allow-unsafe-pr-checkout.

test:integration reports 0 passing before and after, because the
webpack build never emits out/test/. That step exists to launch VS
Code and exit clean, and it does again. The 150 tests CI reports come
from test:unit-tests.

Test plan

  • npx vscode-test on main reproduces the macOS failure, and passes
    with these changes
  • Test (macos), Test (linux) and Test (windows) green on this
    PR
  • Verify changelog fragment green on the next bugfix or feature
    PR. It is skipped here since this is :seedling:

Signed-off-by: Fabian von Feilitzsch fabian@fabianism.us
Co-authored-by: Claude Opus 5 (1M context) noreply@anthropic.com
Signed-off-by: Cherry Picker noreply@github.com

## Summary

`Test (macos)` has been failing on every PR since VS Code 1.131.0
shipped, and `Verify changelog fragment` fails on every fork PR. Both
are broken on main, not by any particular change. Confirmed by running
`npx vscode-test` on a clean `ed42f5a` checkout.

- 1.131.0 dropped `Contents/MacOS/Electron` for `Contents/MacOS/Code`,
and `@vscode/test-electron` 2.x still spawns the old name.
`.vscode-test.mjs` pins no version so it picks up stable at run time,
which is why this started on its own. #1477 passed on 1.130.0. macOS
failing then cancels linux and windows via fail-fast, so all three go
red.
- Bump `@vscode/test-electron` to 3.x. That gets it launching and
exposes a second macOS failure underneath: VS Code opens a unix socket
in its user data dir, and the default `.vscode-test/user-data` path is
over the 104 byte `sun_path` limit. CI's macOS path is exactly 104, so
the bump on its own would have swapped one failure for another. Point
`--user-data-dir` at a short temp path.
- `@vscode/test-cli` stops at 0.0.14 on purpose. 0.0.15 pulls
`yargs@18`, which wants node `^22.12.0`, and `.nvmrc` is v22.9.0, so
install dies with EBADENGINE before anything runs. Bumping `.nvmrc`
would also work but that is a bigger call than this PR should make.
- The changelog job checks out the PR head, which `actions/checkout` now
refuses under `pull_request_target` since that runs fork code with a
privileged token. It only needs the changed filenames, so ask the API
for them instead. Avoids opting into `allow-unsafe-pr-checkout`.

`test:integration` reports 0 passing before and after, because the
webpack build never emits `out/test/`. That step exists to launch VS
Code and exit clean, and it does again. The 150 tests CI reports come
from `test:unit-tests`.

## Test plan

- [x] `npx vscode-test` on main reproduces the macOS failure, and passes
with these changes
- [x] `Test (macos)`, `Test (linux)` and `Test (windows)` green on this
PR
- [ ] `Verify changelog fragment` green on the next bugfix or feature
PR. It is skipped here since this is `:seedling:`

Signed-off-by: Fabian von Feilitzsch <fabian@fabianism.us>
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
Signed-off-by: Cherry Picker <noreply@github.com>
@fabianvf
fabianvf merged commit 72ecedf into release-0.6 Aug 6, 2026
20 checks passed
@fabianvf
fabianvf deleted the cherry-pick-pr1480-release-0.6 branch August 6, 2026 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants